Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-resources): buffers returned by AwsCustomResource are unusable #9977

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Aug 26, 2020

Convert buffers to strings when flattening the API response.

Closes #9969, closes #10017


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…sable

Convert buffers to strings when flattening the API response.

Closes aws#9969
@jogold jogold changed the title fix(custom-resources): buffers returned by AwsCustomResources are unusable fix(custom-resources): buffers returned by AwsCustomResource are unusable Aug 26, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5e54caa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7f351ff into aws:master Aug 28, 2020
@jogold jogold deleted the cr-flatten-buffer branch September 4, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants