Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): multiple library copies lead to 'Assets must be defined within Stage or App' error #11113

Merged
merged 3 commits into from Nov 2, 2020
Merged

fix(core): multiple library copies lead to 'Assets must be defined within Stage or App' error #11113

merged 3 commits into from Nov 2, 2020

Commits on Oct 26, 2020

  1. fix(core): make Stage compatible to instances from other copies of code 

    A recent change surfaces an issue where Stage objects from different
code copies don't recognize each other as a Stage. This paht aligns
the way how a Stage determines if something is a Stage to the same
mechanism that App and Stack use.

Thanks to @Shogan and @jogold to narrowing the issue down

fixes #10314
    @mrgrain
    mrgrain committed Oct 26, 2020
    Copy the full SHA
    336d096 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. Merge branch 'master' into mrgrain/allow-multiple-code-instances-of-core

    @mergify
    mergify[bot] committed Nov 2, 2020
    Copy the full SHA
    218194c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mrgrain/allow-multiple-code-instances-of-core

    @mergify
    mergify[bot] committed Nov 2, 2020
    Copy the full SHA
    51b8f3f View commit details
    Browse the repository at this point in the history