feat(cdk-assets): add external asset support #12259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/assets
CaerusKaru
changed the title
CaerusKaru
force-pushed
the
master
branch
2 times, most recently
from
9213a1c
to
b8a7047
Compare
|
@CaerusKaru this is interesting. Have you discussed this with anyone from the CDK team before submitting? I suspect we may want a quick RFC to better understand the use case behind this and see if this is indeed the best approach. |
eladb
reviewed
Dec 29, 2020
packages/@aws-cdk/cloud-assembly-schema/lib/assets/docker-image-asset.ts
Outdated
Show resolved
Hide resolved
rix0rrr
reviewed
Jan 4, 2021
packages/@aws-cdk/core/lib/stack-synthesizers/bootstrapless-synthesizer.ts
Outdated
Show resolved
Hide resolved
rix0rrr
reviewed
Jan 4, 2021
rix0rrr
reviewed
Jan 4, 2021
added 2 commits
January 5, 2021 04:27
In the event that assets are not actually available at synthesis time, we still want to support JIT (just-in-time) asset generation via external tooling. This would, for instance, enable a third party tool to fetch additional resources prior to bundling/building and subsequent uploading. This adds a new interface for both File and Docker asset types that allows users to specify an executable. The executable, depending on the asset type, must then reply with a specific key on stdout, which will then get picked up and used by CDK Assets. This also updates the default stack synthesizer to support adding external sources directly. This is technically a breaking change for anyone who currently extends the class.
rix0rrr
reviewed
Jan 5, 2021
packages/@aws-cdk/cloud-assembly-schema/schema/cloud-assembly.version.json
Outdated
Show resolved
Hide resolved
rix0rrr
reviewed
Jan 5, 2021
packages/@aws-cdk/core/lib/stack-synthesizers/stack-synthesizer.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/core/lib/stack-synthesizers/stack-synthesizer.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/core/lib/stack-synthesizers/stack-synthesizer.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/core/lib/stack-synthesizers/default-synthesizer.ts
Outdated
Show resolved
Hide resolved
packages/cdk-assets/lib/private/handlers/external-container-images.ts
Outdated
Show resolved
Hide resolved
rix0rrr
previously approved these changes
Jan 7, 2021
rix0rrr
previously approved these changes
Jan 7, 2021
rix0rrr
previously approved these changes
Jan 7, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
previously approved these changes
Jan 8, 2021
|
@Mergifyio update |
|
@CaerusKaru is not allowed to run commands |
rix0rrr
approved these changes
Jan 11, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that assets are not actually available at synthesis
time, we still want to support JIT (just-in-time) asset
generation via external tooling. This would, for instance, enable
a third party tool to fetch additional resources prior to
bundling/building and subsequent uploading.
This adds a new interface for both File and Docker asset types
that allows users to specify an executable. The executable,
depending on the asset type, must then reply with a specific key
on stdout, which will then get picked up and used by CDK Assets.
This also updates the default stack synthesizer to support adding
external sources directly. This is technically a breaking change
for anyone who currently extends the class.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license