Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iam): not possible to represent Principal: * #16843

Merged
merged 3 commits into from
Oct 7, 2021
Merged

fix(iam): not possible to represent Principal: * #16843

merged 3 commits into from
Oct 7, 2021

Commits on Oct 7, 2021

  1. fix(iam): not possible to represent Principal: * 

    Some service's resource policies require the specification of
`Principal: *`, and will not accept `Principal: { AWS: * }`.

Our code was making assumptions that the two were compatible, and could
be interchangeably used. Our modelling made it impossible to represent
`Principal: *`.

- Fix an issue in `PolicyStatement.fromJson()` which would incorrectly normalize
  away `Principal: *`.
- Add a new principal class, `StarPrincipal`, which represents the
  principal of that type in the CDK object model.
    @rix0rrr
    rix0rrr committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    7dedf96 View commit details
    Browse the repository at this point in the history

  2. Fix readonly

    @rix0rrr
    rix0rrr committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    b8aa547 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into huijbers/no-normalization

    @mergify
    mergify[bot] committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    84b1a66 View commit details
    Browse the repository at this point in the history