Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-eks): support bottlerocket managed nodegroup #17323

Merged
merged 17 commits into from Nov 12, 2021
Merged

feat(aws-eks): support bottlerocket managed nodegroup #17323

merged 17 commits into from Nov 12, 2021

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Nov 4, 2021

Support Bottlerocket managed nodegroups and update the README as Bottlerocket has been supported in all AWS commercial regions since its GA.

Fixes: #17324


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 4, 2021

@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Nov 4, 2021
@pahud pahud marked this pull request as ready for review November 11, 2021 06:43
@pahud
Copy link
Contributor Author

pahud commented Nov 11, 2021

@neilkuan 🆗

Copy link
Contributor

@neilkuan neilkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pahud
Copy link
Contributor Author

pahud commented Nov 11, 2021

Hi @otaviomacedo can you take a look?

packages/@aws-cdk/aws-eks/README.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed otaviomacedo’s stale review November 12, 2021 01:06

Pull request has been modified.

@pahud
Copy link
Contributor Author

pahud commented Nov 12, 2021

@otaviomacedo All addressed. Please take a look again.

Fixed typo.
otaviomacedo
otaviomacedo previously approved these changes Nov 12, 2021
@mergify mergify bot dismissed otaviomacedo’s stale review November 12, 2021 09:32

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f77c3b7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2e6a1a9 into aws:master Nov 12, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Support Bottlerocket managed nodegroups and update the README as Bottlerocket has been supported in all AWS commercial regions since its [GA](https://aws.amazon.com/tw/about-aws/whats-new/2020/08/announcing-general-availability-of-bottlerocket/).

Fixes: aws#17324

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-eks): support bottlerocket managed nodegroup
4 participants