Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelines): support timeout in CodeBuildStep #17351

Merged
merged 7 commits into from
Jan 4, 2022

Conversation

berenddeboer
Copy link
Contributor

Make sure we can set timeout for those long running tests.

There's one thing I didn't get. In _codebuild-factory.ts/produceAction() I expected that this line:

    const projectOptions = mergeCodeBuildOptions(options.codeBuildDefaults, this.props.projectOptions);

would merge in the timeout if set. But it didn't do that. So that's why I pull the timeout in the later codebuild.PipelineProject explicitly via:

      timeout: this.props.projectOptions?.timeout,

Not sure why I had to do that. I noticed that options.codeBuildDefaults didn't have the timeout field, perhaps that's why the merge didn't work, or perhaps I don't understand this merge, and what I did was right :-)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 5, 2021

@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Nov 5, 2021
@berenddeboer
Copy link
Contributor Author

I don't think this build failure is my fault:

npm ERR! notarget No matching version found for @aws-cdk/aws-panorama@1.130.0.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 24, 2021

I expected that [mergeCodeBuildOptions] would merge in the timeout if set. But it didn't do that.

But you could make it do that?

rix0rrr
rix0rrr previously approved these changes Nov 24, 2021
@mergify mergify bot dismissed rix0rrr’s stale review November 24, 2021 17:23

Pull request has been modified.

@berenddeboer
Copy link
Contributor Author

Hi @rix0rrr: it seems you implemented what you asked? I can see this showing up in the merge. Anything else needed from me?

rix0rrr
rix0rrr previously approved these changes Jan 4, 2022
@mergify mergify bot dismissed rix0rrr’s stale review January 4, 2022 13:46

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b973e3c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2aa3b8e into aws:master Jan 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Make sure we can set timeout for those long running tests.

There's one thing I didn't get. In `_codebuild-factory.ts/produceAction()` I expected that this line:

```
    const projectOptions = mergeCodeBuildOptions(options.codeBuildDefaults, this.props.projectOptions);
```

would merge in the timeout if set. But it didn't do that. So that's why I pull the timeout in the later `codebuild.PipelineProject` explicitly via:

```
      timeout: this.props.projectOptions?.timeout,
```

Not sure why I had to do that. I noticed that `options.codeBuildDefaults` didn't have the timeout field, perhaps that's why the merge didn't work, or perhaps I don't understand this merge, and what I did was right :-)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants