feat(ec2): create Peers via security group ids #18248
Conversation
Allows users to add ingress/egress security group rules containing a security group id using the Peer interface. Implements aws#7111
|
|
github-actions
bot
added
the
@aws-cdk/aws-ec2
There was a problem hiding this comment.
Looks good!
However, I do question whether allowing the ownership information to be optional makes sense, given it then just replicates the behavior of SecurityGroup.
Also, can you update the docstring for the Peer class as part of this? The last paragraph explicitly mentions Security Groups and looks like it needs a slight update as part of this.
njlynch
added
the
pr-linter/exempt-readme
njlynch
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Allows users to add ingress/egress security group rules containing a security group id using the Peer interface. Implements aws#7111 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Allows users to add ingress/egress security group rules containing a security group id using the Peer interface.
Implements #7111
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license