Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "chore(ec2): enforceSSL on flowLog s3 bucket (#18271)" #18770

Merged
merged 2 commits into from Feb 1, 2022

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Feb 1, 2022

#18271 resulted in the definition of a new bucket policy, which broke existing users that already had an implicit bucket policy created by AWS (see docs).

Reverts commit 0ed5e85 in the meantime until we figure out the longer term solution.

Fixes #18676


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 1, 2022

@eladb eladb requested a review from corymhall February 1, 2022 15:56
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Feb 1, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@eladb eladb changed the title Revert "chore(ec2): enforceSSL on flowLog s3 bucket (#18271)" revert: "chore(ec2): enforceSSL on flowLog s3 bucket (#18271)" Feb 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a2eb092 into master Feb 1, 2022
@mergify mergify bot deleted the benisrae/revert-18271 branch February 1, 2022 20:18
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 30e9d9a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…s#18770)

aws#18271 resulted in the definition of a new bucket policy, which broke existing users that already had an implicit bucket policy created by AWS (see [docs](https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/AWS-logs-and-resource-policy.html#AWS-logs-infrastructure-S3)).

Reverts commit 0ed5e85 in the meantime until we figure out the longer term solution.

Fixes aws#18676


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud contribution/core This is a PR that came from AWS.
Projects
None yet
3 participants