Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rds): read replica instance cannot join domain #19202

Merged
merged 4 commits into from
Mar 1, 2022
Merged

fix(rds): read replica instance cannot join domain #19202

merged 4 commits into from
Mar 1, 2022

Commits on Mar 1, 2022

  1. fix(rds): read replica instance cannot join domain 

    The read replica instance always uses the same engine as the source instance
but some CF validations require the engine to be explicitely passed when some
properties are specified.

Pass the `engine` property to the CF resource if `domain` is specified.

Closes aws#18786
    @jogold
    jogold committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    628cf6a View commit details
    Browse the repository at this point in the history

  2. Update packages/@aws-cdk/aws-rds/lib/instance.ts

    @jogold
    jogold committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    e33b774 View commit details
    Browse the repository at this point in the history

  3. remove anyDefined

    @jogold
    jogold committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    9c2d49e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into rds-replica-engine

    @jogold
    jogold committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    8902c6a View commit details
    Browse the repository at this point in the history