fix(rds): read replica instance cannot join domain #19202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The read replica instance always uses the same engine as the source instance but some CF validations require the engine to be explicitely passed when some properties are specified. Pass the `engine` property to the CF resource if `domain` is specified. Closes aws#18786
|
|
github-actions
bot
added
the
@aws-cdk/aws-rds
jogold
commented
Mar 1, 2022
skinny85
reviewed
Mar 1, 2022
| SourceDBInstanceIdentifier: Match.anyValue(), | ||
| Engine: 'postgres', | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I wonder... since this is a CFN validation, do we need a new small integration test for this, to confirm it deploys?
There was a problem hiding this comment.
Ideally yes but it's complicated because it means we need to create a domain using L1 resources from @aws-cdk/aws-directoryservice... and I don't have experience with those resources.
(domain is currently a string but could have been a IDirectory if we had L2 resources for this)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TheRealAmazonKendra
pushed a commit
to TheRealAmazonKendra/aws-cdk
that referenced
this pull request
Mar 11, 2022
The read replica instance always uses the same engine as the source instance but some CF validations require the engine to be explicitely passed when some properties are specified. Pass the `engine` property to the CF resource if `domain` is specified. Closes aws#18786 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read replica instance always uses the same engine as the source instance
but some CF validations require the engine to be explicitely passed when some
properties are specified.
Pass the
engineproperty to the CF resource ifdomainis specified.Closes #18786
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license