Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-nodejs): local tsc detection with pre compilation #19266

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Mar 7, 2022

The package name is typescript, the bin is tsc.

Closes #19242


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The package name is `typescript`, the bin is `tsc`.

Closes aws#19242
@gitpod-io
Copy link

gitpod-io bot commented Mar 7, 2022

@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9dd37ec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5de7b86 into aws:master Mar 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TheRealAmazonKendra pushed a commit to TheRealAmazonKendra/aws-cdk that referenced this pull request Mar 11, 2022
The package name is `typescript`, the bin is `tsc`.

Closes aws#19242


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@jogold jogold deleted the lambda-nodejs-tsc-detection branch March 12, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(aws-lambda-nodejs): esbuild preCompilation not finding local tsc
3 participants