Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): NestedStack defaultChild is undefined #20450

Merged
merged 2 commits into from
May 24, 2022
Merged

fix(core): NestedStack defaultChild is undefined #20450

merged 2 commits into from
May 24, 2022

Conversation

Jacco
Copy link
Contributor

@Jacco Jacco commented May 21, 2022

fixes #11221

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 21, 2022

@github-actions github-actions bot added the p2 label May 21, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team May 21, 2022 09:30
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 and removed p2 labels May 21, 2022
@Jacco Jacco changed the title bug(11221) NestedStack defaultChild fix(core) NestedStack defaultChild May 21, 2022
@Jacco Jacco changed the title fix(core) NestedStack defaultChild fix(core): NestedStack defaultChild May 21, 2022
@rix0rrr rix0rrr changed the title fix(core): NestedStack defaultChild fix(core): NestedStack defaultChild is undefined May 24, 2022
@rix0rrr
Copy link
Contributor

rix0rrr commented May 24, 2022

Thanks!

@mergify
Copy link
Contributor

mergify bot commented May 24, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 60acc21
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0a49927 into aws:master May 24, 2022
@mergify
Copy link
Contributor

mergify bot commented May 24, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cloudformation] NestedStack doesn't have defaultChild
3 participants