feat(apprunner): VpcConnector construct #20471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
effort/medium
DDynamic
force-pushed
the
apprunner-vpc-connector
branch
from
16bc397
to
8228206
Compare
corymhall
previously requested changes
May 24, 2022
There was a problem hiding this comment.
@DDynamic thanks for taking this on! Most of my initial review is based on making sure this construct aligns with our design guidelines. I would also recommend taking a look at our example construct library.
DDynamic
force-pushed
the
apprunner-vpc-connector
branch
from
63a1ad5
to
dd9e647
Compare
corymhall
previously approved these changes
May 25, 2022
DDynamic
force-pushed
the
apprunner-vpc-connector
branch
from
1c7686a
to
851933d
Compare
corymhall
approved these changes
May 25, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18887
vpcConnectorproperty. When present, associate the service with the connector.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license