Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(batch): fix test that cannot pass #21566

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

TheRealAmazonKendra
Copy link
Contributor

JobQueue has a limit of three compute environments but one of the queues in this test
have four. This separates it out into it's own queue so that this test succeeds.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

JobQueue has a limit of three compute environments but one of the queues in this test
have four. This separates it out into it's own queue so that this test succeeds.
@gitpod-io
Copy link

gitpod-io bot commented Aug 11, 2022

@github-actions github-actions bot added the p2 label Aug 11, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 11, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 11, 2022 21:11
@TheRealAmazonKendra
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2022

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b1084e8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3f5d6d8 into main Aug 11, 2022
@mergify mergify bot deleted the TheRealAmazonKendra/batch-test-fix branch August 11, 2022 21:58
josephedward pushed a commit to josephedward/aws-cdk that referenced this pull request Aug 30, 2022
JobQueue has a limit of three compute environments but one of the queues in this test
have four. This separates it out into it's own queue so that this test succeeds.


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants