chore(integ-runner): use newStyleSynthesis by default #21856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Naumel
approved these changes
Aug 31, 2022
aws-amplify-alpha so removing the piece that causes the failure (diff in nested stack asset hash).
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
18 tasks
4 tasks
hacker65536
pushed a commit
to hacker65536/aws-cdk
that referenced
this pull request
Sep 30, 2022
This PR updates the `integ-runner` to _not_ set `@aws-cdk/core:newStyleStackSynthesis: false` by default. Previously this was done to cut down on the merge conflicts when the forward-merge was done between v1 and v2, but since we are now only committing to v2 it makes sense to test with `newStyleStackSynthesis` enabled. This change required re-running _all_ integration tests since using this flag changes the template. I've separated out some of the important changes into their own commits to make it easier to review. - `chore(integ-runner): use newStyleSynthesis by default` - this contains the actual change to the `integ-runner` - `integ test shapshot updates` - this contains the snapshot updates for most of the tests - The commits that mention a specific module contain fixes for broken integration tests ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
integ-runnerto not set@aws-cdk/core:newStyleStackSynthesis: falseby default.Previously this was done to cut down on the merge conflicts when the forward-merge was done
between v1 and v2, but since we are now only committing to v2 it makes sense to test with
newStyleStackSynthesisenabled.This change required re-running all integration tests since using this flag changes the template. I've separated out some of the important changes into their own commits to make it easier to review.
chore(integ-runner): use newStyleSynthesis by default- this contains the actual change to theinteg-runnerinteg test shapshot updates- this contains the snapshot updates for most of the testsAll Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license