Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove and ignore intermediate snapshots integration test snapshots #22731

Merged

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 1, 2022

When running integration tests, they are executed inside an intermediate directory named cdk-integ.out.*. These files should never be committed to version control. This change removes the last few accidentally committed files, and adds a global gitignore rule to prevent any files being added in future.

The unit tests for integ-runner rely on these (fake) intermediate artifacts for assertions, so they are still included. However these aren't real integreation tests anyway.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 1, 2022

@github-actions github-actions bot added the p2 label Nov 1, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team November 1, 2022 14:35
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 1, 2022
@mrgrain mrgrain force-pushed the chore/remove-integ-test-intermediate-snapshots branch from 5f70289 to 0363f4e Compare November 1, 2022 14:55
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8d5c422
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 29254fe into aws:main Nov 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain deleted the chore/remove-integ-test-intermediate-snapshots branch July 26, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants