Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ec2): remove c6gbd instance since it doesn't exist and cleanup other instance types for the sake of consistency #23145

Merged
merged 4 commits into from
Dec 12, 2022
Merged

chore(ec2): remove c6gbd instance since it doesn't exist and cleanup other instance types for the sake of consistency #23145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bfa3088
fix(ec2): Remove c6gbd instance since it doesn't exist and cleanup ot…
robertd Nov 29, 2022
4784c24
add awslint exclude line for breaking change
robertd Nov 29, 2022
f93d185
try again
robertd Dec 8, 2022
3f81bb7
Merge branch 'main' into minor-fix
mergify[bot] Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions allowed-breaking-changes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,3 +148,5 @@ incompatible-argument:@aws-cdk/aws-route53-targets.InterfaceVpcEndpointTarget.<i
# to allow the CLI to skip validating the bootstrap stack when the stack is not needed
changed-type:@aws-cdk/cx-api.AssetManifestArtifact.requiresBootstrapStackVersion

# removed mistyped ec2 instance class
removed:aws-cdk-lib.aws_ec2.InstanceClass.COMPUTE6_GRAVITON2_HIGH_NETWORK_BANDWITH
13 changes: 3 additions & 10 deletions packages/@aws-cdk/aws-ec2/lib/instance-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ export enum InstanceClass {
/**
* Compute optimized instances for high performance computing, 7th generation with Graviton3 processors
*/
COMPUTE7_GRAVITON3 = 'compute7_graviton3',
COMPUTE7_GRAVITON3 = 'compute7-graviton3',

/**
* Compute optimized instances for high performance computing, 7th generation with Graviton3 processors
Expand All @@ -440,12 +440,6 @@ export enum InstanceClass {
*/
C6GD = 'c6gd',

/**
* Compute optimized instances for high performance computing, 6th generation with Graviton2 processors
* and high network bandwidth capabilities
*/
COMPUTE6_GRAVITON2_HIGH_NETWORK_BANDWITH = 'compute6-graviton2-high-network-banwidth',
robertd marked this conversation as resolved.
Show resolved Hide resolved

/**
* Compute optimized instances for high performance computing, 6th generation with Graviton2 processors
* and high network bandwidth capabilities
Expand Down Expand Up @@ -1135,11 +1129,10 @@ export class InstanceType {
[InstanceClass.C6G]: 'c6g',
[InstanceClass.COMPUTE6_GRAVITON2_NVME_DRIVE]: 'c6gd',
[InstanceClass.C6GD]: 'c6gd',
[InstanceClass.COMPUTE6_GRAVITON2_HIGH_NETWORK_BANDWIDTH]: 'c6gdb',
[InstanceClass.COMPUTE6_GRAVITON2_HIGH_NETWORK_BANDWITH]: 'c6gdb',
[InstanceClass.COMPUTE6_GRAVITON2_HIGH_NETWORK_BANDWIDTH]: 'c6gn',
[InstanceClass.C6GN]: 'c6gn',
[InstanceClass.COMPUTE7_GRAVITON3]: 'c7g',
[InstanceClass.C7G]: 'c7g',
[InstanceClass.C6GN]: 'c6gn',
[InstanceClass.STORAGE2]: 'd2',
[InstanceClass.D2]: 'd2',
[InstanceClass.STORAGE3]: 'd3',
Expand Down