Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ec2): remove c6gbd instance since it doesn't exist and cleanup other instance types for the sake of consistency #23145

Merged
merged 4 commits into from
Dec 12, 2022

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Nov 29, 2022

Remove c6gbd instance since it doesn't exist and cleanup other instance types for the sake of consistency.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 29, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team November 29, 2022 17:39
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Nov 29, 2022
@robertd
Copy link
Contributor Author

robertd commented Nov 29, 2022

@corymhall I'm working on this PR... I'll convert it to draft mode.

@robertd robertd marked this pull request as draft November 29, 2022 18:27
@robertd robertd changed the title chore(ec2): instance type cleanup for the sake of consistency fix(ec2): Remove c6gbd instance since it doesn't exist and cleanup other instance types for the sake of consistency Nov 29, 2022
@robertd robertd marked this pull request as ready for review November 29, 2022 18:29
@robertd
Copy link
Contributor Author

robertd commented Nov 29, 2022

@corymhall I've converted this PR from chore to fix since I wasn't able to find c6gbd instance in docs nor through aws cli. I believe this may have been an omission when packages/@aws-cdk/aws-ec2/lib/instance-types.ts file got refactored.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@corymhall corymhall self-assigned this Nov 30, 2022
@robertd robertd force-pushed the minor-fix branch 2 times, most recently from 8fa37fe to 6f67e9b Compare November 30, 2022 23:49
@robertd robertd changed the title fix(ec2): Remove c6gbd instance since it doesn't exist and cleanup other instance types for the sake of consistency fix(ec2): remove c6gbd instance since it doesn't exist and cleanup other instance types for the sake of consistency Dec 1, 2022
@robertd robertd force-pushed the minor-fix branch 2 times, most recently from d975721 to 5535674 Compare December 1, 2022 14:16
@robertd
Copy link
Contributor Author

robertd commented Dec 1, 2022

@corymhall yelp.... I need help with awslint :(

@robertd robertd force-pushed the minor-fix branch 3 times, most recently from 54c194c to f92c24e Compare December 8, 2022 16:47
@robertd
Copy link
Contributor Author

robertd commented Dec 8, 2022

@corymhall It worked. Thanks. I’m surprised that previous entries in the allowed-breaking-changes.txt are not throwing a fit given that they’re using old naming.

Anyways, rebasing really quick and it’s ready for your review.

@corymhall corymhall changed the title fix(ec2): remove c6gbd instance since it doesn't exist and cleanup other instance types for the sake of consistency chore(ec2): remove c6gbd instance since it doesn't exist and cleanup other instance types for the sake of consistency Dec 12, 2022
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 12, 2022 18:20

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@corymhall corymhall dismissed aws-cdk-automation’s stale review December 12, 2022 18:22

should have been dismissed by automation

@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3f81bb7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6e4b4ea into aws:main Dec 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@robertd robertd deleted the minor-fix branch December 12, 2022 19:54
brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Jan 20, 2023
…other instance types for the sake of consistency (aws#23145)

Remove `c6gbd` instance since it doesn't exist and cleanup other instance types for the sake of consistency.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Feb 22, 2023
…other instance types for the sake of consistency (aws#23145)

Remove `c6gbd` instance since it doesn't exist and cleanup other instance types for the sake of consistency.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants