chore(cli): integ test current version against all supported versions of TS #23244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mrgrain
added
p1
pr/do-not-merge
|
|
mrgrain
force-pushed
the
mrgrain/chore/test-with-all-ts-versions
branch
2 times, most recently
from
7ee5458
to
d39f7bf
Compare
mrgrain
force-pushed
the
mrgrain/chore/test-with-all-ts-versions
branch
from
d39f7bf
to
f4fe0c8
Compare
mrgrain
added
pr-linter/cli-integ-tested
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio unqueue |
✅ The pull request has been removed from the queue |
4 tasks
mrgrain
force-pushed
the
mrgrain/chore/test-with-all-ts-versions
branch
from
f4fe0c8
to
cfcbdc7
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mrgrain
force-pushed
the
mrgrain/chore/test-with-all-ts-versions
branch
from
cfcbdc7
to
57c4a1f
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mrgrain
force-pushed
the
mrgrain/chore/test-with-all-ts-versions
branch
from
57c4a1f
to
596c67a
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mrgrain
changed the title
mrgrain
added
pr/do-not-merge
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Dec 9, 2022
… of TS (aws#23244) We currently only test against a single TS version as defined in the init-templates. This change will run these tests against all supported TS minor versions (currently `typescript@>=3.9`). A recent change on main that broke support for >=TS4.0 went undetected due to missing these tests. Tests are about 2min per TS version, with a total of 11 supported versions, these tests will now take 22min instead of 2min. Other actions in the same pipeline stage take 25min and over 50min (docs), so this shouldn't have an effect on total pipeline runtime. ~This PR is based off and tested with the last released version (v2.53.0), as `main` is currently not building.~ ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Jan 20, 2023
… of TS (aws#23244) We currently only test against a single TS version as defined in the init-templates. This change will run these tests against all supported TS minor versions (currently `typescript@>=3.9`). A recent change on main that broke support for >=TS4.0 went undetected due to missing these tests. Tests are about 2min per TS version, with a total of 11 supported versions, these tests will now take 22min instead of 2min. Other actions in the same pipeline stage take 25min and over 50min (docs), so this shouldn't have an effect on total pipeline runtime. ~This PR is based off and tested with the last released version (v2.53.0), as `main` is currently not building.~ ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Feb 22, 2023
… of TS (aws#23244) We currently only test against a single TS version as defined in the init-templates. This change will run these tests against all supported TS minor versions (currently `typescript@>=3.9`). A recent change on main that broke support for >=TS4.0 went undetected due to missing these tests. Tests are about 2min per TS version, with a total of 11 supported versions, these tests will now take 22min instead of 2min. Other actions in the same pipeline stage take 25min and over 50min (docs), so this shouldn't have an effect on total pipeline runtime. ~This PR is based off and tested with the last released version (v2.53.0), as `main` is currently not building.~ ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only test against a single TS version as defined in the init-templates. This change will run these tests against all supported TS minor versions (currently
typescript@>=3.9). A recent change on main that broke support for >=TS4.0 went undetected due to missing these tests.Tests are about 2min per TS version, with a total of 11 supported versions, these tests will now take 22min instead of 2min. Other actions in the same pipeline stage take 25min and over 50min (docs), so this shouldn't have an effect on total pipeline runtime.
This PR is based off and tested with the last released version (v2.53.0), asmainis currently not building.All Submissions:
Adding new Construct Runtime Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license