Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-cloudfront): Added support for managed origin policy "AllViewerAndCloudFrontHeaders-2022-06" #23358

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

cameroncf
Copy link
Contributor

This adds support for the managed policy "AllViewerAndCloudFrontHeaders-2022-06", added earlier this year, which includes newer CloudFront Headers such as CloudFront-Viewer-Latitude CloudFront-Viewer-Longitude.

Detail about this managed policy:
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/using-managed-origin-request-policies.html#managed-origin-request-policy-all-viewer-and-cloudfront


All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • [NO] Have you added the new feature to an integration test?
    • [NO] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ontHeaders-2022-06

This adds support for the managed policy "AllViewerAndCloudFrontHeaders-2022-06", which includes newer CloudFront Headers such as CloudFront-Viewer-Latitude CloudFront-Viewer-Longitude.

Detail about this managed policy:
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/using-managed-origin-request-policies.html#managed-origin-request-policy-all-viewer-and-cloudfront
@gitpod-io
Copy link

gitpod-io bot commented Dec 15, 2022

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Dec 15, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team December 15, 2022 14:20
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@cameroncf
Copy link
Contributor Author

I don't think this change requires any README or snapshot updates. Please let me know if I'm wrong.

@corymhall corymhall changed the title feat(aws-cloudfront): Added support for managed origin policy "AllViewerAndCloudFrontHeaders-2022-06" chore(aws-cloudfront): Added support for managed origin policy "AllViewerAndCloudFrontHeaders-2022-06" Dec 19, 2022
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 19, 2022 19:14

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Dec 19, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@corymhall corymhall self-assigned this Dec 19, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6ed4d2c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4acfc6a into aws:main Dec 19, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 19, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Jan 20, 2023
…ewerAndCloudFrontHeaders-2022-06" (aws#23358)

This adds support for the managed policy "AllViewerAndCloudFrontHeaders-2022-06", added earlier this year, which includes newer CloudFront Headers such as CloudFront-Viewer-Latitude CloudFront-Viewer-Longitude.

Detail about this managed policy:
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/using-managed-origin-request-policies.html#managed-origin-request-policy-all-viewer-and-cloudfront

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [NO] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [NO] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Feb 22, 2023
…ewerAndCloudFrontHeaders-2022-06" (aws#23358)

This adds support for the managed policy "AllViewerAndCloudFrontHeaders-2022-06", added earlier this year, which includes newer CloudFront Headers such as CloudFront-Viewer-Latitude CloudFront-Viewer-Longitude.

Detail about this managed policy:
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/using-managed-origin-request-policies.html#managed-origin-request-policy-all-viewer-and-cloudfront

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [NO] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [NO] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants