Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): add insights version 1.0.178.0 #23836

Merged
merged 6 commits into from
Feb 13, 2023
Merged

Conversation

kaizencc
Copy link
Contributor


All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 25, 2023

@github-actions github-actions bot added the p2 label Jan 25, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 25, 2023 18:32
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 25, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@kaizencc kaizencc marked this pull request as draft January 25, 2023 19:13
@kaizencc
Copy link
Contributor Author

Need to register eu-central-2 first in a separate PR

@TheRealAmazonKendra
Copy link
Contributor

REJECTED.

Just kidding, but are there any tests that we can add for a change like this?

@kaizencc
Copy link
Contributor Author

Depends on #24110

@kaizencc kaizencc marked this pull request as ready for review February 10, 2023 17:50
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Feb 13, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 13, 2023 17:29

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9ce352b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5272908 into main Feb 13, 2023
@mergify mergify bot deleted the conroy/lambda-insights branch February 13, 2023 19:01
@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants