fix: Use the correct LB full name when creating metrics for imported LBs #23972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
p2
beginning-contributor
edisongustavo
force-pushed
the
main
branch
2 times, most recently
from
91aa377
to
3b2c202
Compare
|
Tagging @comcalvi who reviewed the previous PR. |
The Arn.split() method doesn't parse the `resourceName` correctly when it has multiple `/`, which is the case for the resources created by by the elbv2 API. I've also refactored the integ.nlb-lookup.ts test because it was not well written and I couldn't really deploy it with Cloudformation.
comcalvi
approved these changes
Feb 8, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Arn.split()method doesn't parse theresourceNamecorrectly when it has multiple/, which is the case for the resources created by by the elbv2 API.I've also refactored the
integ.nlb-lookup.tstest because it was not well written and I couldn't really deploy it with Cloudformation.The capability to create metrics from imported Load Balancers is new. It was introduced in #23853.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license