Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoscaling): L2 construct for enabling capacity rebalance of autoscaling #24025

Merged
merged 5 commits into from
Feb 10, 2023
Merged

feat(autoscaling): L2 construct for enabling capacity rebalance of autoscaling #24025

merged 5 commits into from
Feb 10, 2023

Conversation

zorrofox
Copy link
Contributor

@zorrofox zorrofox commented Feb 6, 2023 •
edited

Add L2 construct for enabling capacity rebalance of autoscaling

Closes #22625.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 6, 2023

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Feb 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team February 6, 2023 06:54
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@zorrofox zorrofox changed the title (feat)aws_autoscaling: L2 construct for enabling capacity rebalance of autoscaling feat(aws_autoscaling): L2 construct for enabling capacity rebalance of autoscaling Feb 6, 2023
@zorrofox zorrofox changed the title feat(aws_autoscaling): L2 construct for enabling capacity rebalance of autoscaling feat(aws-autoscaling): L2 construct for enabling capacity rebalance of autoscaling Feb 6, 2023
@zorrofox zorrofox changed the title feat(aws-autoscaling): L2 construct for enabling capacity rebalance of autoscaling feat(autoscaling): L2 construct for enabling capacity rebalance of autoscaling Feb 6, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 6, 2023 08:03

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@zorrofox zorrofox marked this pull request as ready for review February 6, 2023 08:44
TheRealAmazonKendra
TheRealAmazonKendra approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic. Thank you for your contribution!

@mergify
Copy link
Contributor

mergify bot commented Feb 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 80f1f76
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d2c63f5 into aws:main Feb 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_autoscaling: L2 construct for enabling capacity rebalance of autoscaling group
3 participants
@zorrofox @aws-cdk-automation @TheRealAmazonKendra