Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(stepfunctions-tasks): description for ecs run task with imported #24098

Merged
merged 3 commits into from Feb 10, 2023
Merged

docs(stepfunctions-tasks): description for ecs run task with imported #24098

merged 3 commits into from Feb 10, 2023

Conversation

bun913
Copy link
Contributor

@bun913 bun913 commented Feb 10, 2023

Summary

This PR...

  • Improves the documentation for aws-stepfunctions-tasks.EcsRunTask

Motivation

  • As mentioned in stepfunctions-tasks: run ecs task can use CustomState #24097 , an imported taskdefinition cannot use the Construct of EcsRuntask.
  • However, the current documentation does not specify an alternative, which may lead to a wrong understanding that L1 Construct may have to be used.
  • In fact, we would like to clarify that it is generally possible by using CustomState(L2 Construct)

Closes #24097


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 10, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team February 10, 2023 06:01
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Feb 10, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@bun913 bun913 changed the title docs(aws-stepfunctions-tasks): description for ecs run task with imported docs(stepfunctions-tasks): description for ecs run task with imported Feb 10, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 10, 2023 06:07

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review February 10, 2023 06:24

Pull request has been modified.

@TheRealAmazonKendra
Copy link
Contributor

Don't merge manually. It dismisses our reviews. You can use @Mergifyio update to update the PR, but even that isn't necessary because it's put in the merge train after approval.

@bun913
Copy link
Contributor Author

bun913 commented Feb 10, 2023

@TheRealAmazonKendra

Sorry. I accidentally pressed the wrong button.
I will be careful from now on.

@TheRealAmazonKendra
Copy link
Contributor

No big deal in this case. I'll re-approve, but it will remove our approval every time.

@bun913
Copy link
Contributor Author

bun913 commented Feb 10, 2023

@TheRealAmazonKendra

OK. I understand.
I will wait for a while.

@TheRealAmazonKendra
Copy link
Contributor

@TheRealAmazonKendra

Sorry. I accidentally pressed the wrong button. I will be careful from now on.

No worries, totally happens. Thanks again for the contribution!

@mergify
Copy link
Contributor

mergify bot commented Feb 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 06eef2f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5452b73 into aws:main Feb 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@bun913 bun913 deleted the feat/add-guide-for-sfn-run-ecs-task branch February 10, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stepfunctions-tasks: run ecs task can use CustomState
3 participants