Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): enable set throughput param to CfnVolume #24118

Merged
merged 4 commits into from
Feb 12, 2023
Merged

fix(ec2): enable set throughput param to CfnVolume #24118

merged 4 commits into from
Feb 12, 2023

Conversation

bun913
Copy link
Contributor

@bun913 bun913 commented Feb 11, 2023

EC2.Volume.throughput does not get passed on into CFN

The throughput parameter of the Ec2.Volume class (L2 Construct) was not set to the CfnVolume parameter as described in #24107

Fixed it so that the value is set.

Closes #24107


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Feb 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team February 11, 2023 08:12
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Feb 11, 2023
@gitpod-io
Copy link

gitpod-io bot commented Feb 11, 2023

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@bun913
Copy link
Contributor Author

bun913 commented Feb 11, 2023

Ok. I will fix it later.

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 11, 2023 12:40

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the fix!

@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bf19df2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 32781f8 into aws:main Feb 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@bun913 bun913 deleted the feat/add_throughput_to_ec2_cfn branch February 12, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EC2: EC2.Volume.throughput does not get passed on into CFN
3 participants