Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ecr policy warning always throws #25041

Merged
merged 2 commits into from
Apr 12, 2023
Merged

fix: ecr policy warning always throws #25041

merged 2 commits into from
Apr 12, 2023

Conversation

peterwoodworth
Copy link
Contributor

A change recently added a warning when the policy added to a Repository resource policy. Check length of array instead of existence of array

Closes #25028


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Apr 12, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team April 12, 2023 01:08
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 12, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@peterwoodworth
Copy link
Contributor Author

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 12, 2023
@peterwoodworth
Copy link
Contributor Author

This change does not modify the templates at all. Only dealing with synth-time warning here

@corymhall corymhall added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Apr 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b86475a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c0c3d19 into main Apr 12, 2023
5 checks passed
@mergify mergify bot deleted the peterwoodworth/warningFix branch April 12, 2023 12:43
@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ecr): (false positive policytext errors from Python since #24401)
3 participants