fix(eks): nodegroupName incorrectly assigned #25278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
previously requested changes
Apr 25, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
bhaskerv
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
corymhall
suggested changes
May 24, 2023
| @@ -476,7 +476,7 @@ export class Nodegroup extends Resource implements INodegroup { | |||
| resource: 'nodegroup', | |||
| resourceName: this.physicalName, | |||
| }); | |||
| this.nodegroupName = this.getResourceNameAttribute(resource.ref); | |||
| this.nodegroupName = resource.getAtt('NodegroupName').toString(); | |||
There was a problem hiding this comment.
Suggested change
| this.nodegroupName = resource.getAtt('NodegroupName').toString(); | |
| this.nodegroupName = this.getResourceNameAttribute(resource.attrNodegroupName); |
Can we do this instead?
corymhall
removed
the
pr/needs-community-review
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
1 task
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
### Issue # (if applicable) As #22910 and #25278 were closed for staleness. I am opening a new PR to fix #22442. To avoid breaking change, this PR introduces a new feature flag for the bug fix. Closes #22442 ### The Code for verification ```ts import { App, Stack, aws_eks as eks, aws_ec2 as ec2, CfnOutput, cx_api, } from 'aws-cdk-lib'; const app = new App(); const env = { region: process.env.CDK_DEFAULT_REGION, account: process.env.CDK_DEFAULT_ACCOUNT }; const stack = new Stack(app, 'my-test-stack2', { env }); stack.node.setContext(cx_api.EKS_NODEGROUP_NAME, true); const vpc = ec2.Vpc.fromLookup(stack, 'Vpc', { isDefault: true }); const cluster = new eks.Cluster(stack, 'Cluster', { vpc, version: eks.KubernetesVersion.V1_29, defaultCapacity: 0, }); const ng1 = new eks.Nodegroup(stack, 'ng-1', { cluster, }); const ng2 = cluster.addNodegroupCapacity('ng-2', { nodegroupName: 'custom-name', }); new CfnOutput(stack, 'ng1-name', { value: ng1.nodegroupName }); new CfnOutput(stack, 'ng2-name', { value: ng2.nodegroupName }); ``` The output is like ``` Outputs: my-test-stack2.ng1name = ng19F1EA947-sSziNMzPVkik my-test-stack2.ng2name = custom-name ``` Console: <img width="315" alt="image" src="https://github.com/aws/aws-cdk/assets/278432/019255bd-7d05-43ad-8624-baf5b6eea725"> ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the EKS nodegroupName attribute that was incorrectly being assigned.
Old: cluster-name/nodegroup-name
New: nodegroup-name
Fixes: #22442
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license