feat(glue): Add G.4X and G.8X worker types for AWS Glue #25637
Conversation
|
|
github-actions
bot
added
the
beginning-contributor
racc
changed the title
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
racc
changed the title
aws-cdk-automation
added
pr-linter/exemption-requested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
racc
changed the title
aws-cdk-automation
removed
the
pr-linter/exemption-requested
| @@ -42,8 +42,9 @@ new glue.Job(this, 'ScalaSparkEtlJob', { | |||
| glueVersion: glue.GlueVersion.V4_0, | |||
| script: glue.Code.fromBucket(bucket, 'src/com/example/HelloWorld.scala'), | |||
| className: 'com.example.HelloWorld', | |||
| extraJars: [glue.Code.fromBucket(bucket, 'jars/HelloWorld.jar')], | |||
| extraJars: [glue.Code.fromBucket(bucket, 'jars/HelloWorld.jar')] | |||
There was a problem hiding this comment.
These kinds of commas are not typos, it makes it easier to extend without having to worry if it's the last line or higher up.
| @@ -31,7 +31,7 @@ const script = glue.Code.fromAsset(path.join(__dirname, 'job-script/hello_world. | |||
| glueVersion, | |||
| script, | |||
| }), | |||
| workerType: glue.WorkerType.G_2X, | |||
| workerType: glue.WorkerType.G_8X, | |||
There was a problem hiding this comment.
Why make the tests 4x as expensive?
Add comma back to README.md Make worker type G.1X to save $
|
@Naumel what say ye? |
😆 I see what you did there; nice by-pass of checks. In this case, with the nature of the change, I like it! |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adds new worker types for Glue announced in: https://aws.amazon.com/about-aws/whats-new/2023/05/aws-glue-large-instance-types-generally-available/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license