fix(autoscaling): AutoScalingGroup maxCapacity defaults to minCapacity when using Token #25922
Conversation
|
|
github-actions
bot
added
p2
valued-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
This comment was marked as outdated.
This comment was marked as outdated.
aws-cdk-automation
added
pr-linter/exemption-requested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Added integration test. I withdraw my exemption request. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Related to #25920.
In
AutoScalingGroup,maxCapacitydefaults toMath.max(minCapacity, 1)even whenminCapacityis a Token.Because Token number is always negative number,
maxCapacitywill be set to1whenmaxCapacityisundefinedandminCapacityis a Token.see also #25795 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license