Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(batch): grant execution role logs:CreateLogStream by default #26288

Merged
merged 8 commits into from
Jul 12, 2023
Merged

fix(batch): grant execution role logs:CreateLogStream by default #26288

merged 8 commits into from
Jul 12, 2023

Conversation

comcalvi
Copy link
Contributor

@comcalvi comcalvi commented Jul 7, 2023 •
edited

Grant CreateLogStream to the job definition's execution role by default. Without this permission, jobs will fail if they produce any output, unless logging is specified.

Closes #25675.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 7, 2023

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Jul 7, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 7, 2023 17:37
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 7, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@comcalvi comcalvi added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 7, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 7, 2023 17:43

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@comcalvi
Copy link
Contributor Author

comcalvi commented Jul 7, 2023

adding the exempt-integ-test, because the snapshots have been changed; there's no need to change the test code itself here, the snapshot change is sufficient.

@comcalvi comcalvi requested a review from mrgrain July 11, 2023 01:58
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c16b0b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c755f50 into main Jul 12, 2023
7 checks passed
@mergify mergify bot deleted the createLogStream branch July 12, 2023 11:39
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@comcalvi @bmoffatt
fix(batch): grant execution role logs:CreateLogStream by default (aws…
23df9bc 
…#26288)

Grant `CreateLogStream` to the job definition's execution role by default. Without this permission, jobs will fail if they produce any output, unless `logging` is specified.

Closes aws#25675.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_batch_alpha: Role permissions error after upgrade from v2.73 to v2.79
3 participants
@comcalvi @aws-cdk-automation @mrgrain