Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk): allow bootstrap with policy names with a path #26378

Merged
merged 5 commits into from
Jul 21, 2023
Merged

fix(cdk): allow bootstrap with policy names with a path #26378

merged 5 commits into from
Jul 21, 2023

Conversation

lpizzinidev
Copy link
Contributor

@lpizzinidev lpizzinidev commented Jul 15, 2023 •
edited

Policy names with slashes (/) are not allowed when bootstrapping.

For example:

cdk bootstrap --custom-permissions-boundary aaa/bbb

Would fail:

Error: The permissions boundary name aaa/bbb does not match the IAM conventions.

This fix allows to specify paths in the policy name.

Closes #26320.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 15, 2023 14:53
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 and removed p2 feature-request A feature should be added or improved. effort/medium Medium work item – several days of effort labels Jul 15, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jul 15, 2023
@mrgrain mrgrain added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 17, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 17, 2023
@przemolb
Copy link

Once this has passed all the tests, what is the approximate timeline to get this released and available to everyone?

@przemolb przemolb mentioned this pull request Jul 19, 2023
Closed
@przemolb
Copy link

@lpizzinidev
Do you think it is possible to push it forward, please ?

mrgrain
mrgrain approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the tests. Once merged it will be part of the next scheduled release.

@mrgrain
Copy link
Contributor

mrgrain commented Jul 21, 2023

Execution ID: 7a05e105-dbf8-4d23-9c2a-50a95bd63c32

@mrgrain mrgrain added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Jul 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 21, 2023 12:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 652a39e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1820fc9 into aws:main Jul 21, 2023
6 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@lpizzinidev @bmoffatt
fix(cdk): allow bootstrap with policy names with a path (aws#26378)
643f922 
Policy names with slashes (`/`) are not allowed when bootstrapping.

For example:
```
cdk bootstrap --custom-permissions-boundary aaa/bbb
```
Would fail:
```
Error: The permissions boundary name aaa/bbb does not match the IAM conventions.
```

This fix allows to specify paths in the policy name.

Closes aws#26320.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-cdk: bootstrapping fails due to permissions boundary name not matching the IAM conventions
4 participants
@lpizzinidev @przemolb @mrgrain @aws-cdk-automation