Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad error checks in custom resources #26392

Merged
merged 3 commits into from
Jul 18, 2023
Merged

fix: bad error checks in custom resources #26392

merged 3 commits into from
Jul 18, 2023

Conversation

MrArnoldPalmer
Copy link
Contributor

Fixes bad error checking in custom resoruce for
cross-region-ssm-writer-handler and redshift cluster-reboot.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Fixes bad error checking in custom resoruce for
cross-region-ssm-writer-handler and redshift cluster-reboot.
@aws-cdk-automation aws-cdk-automation requested a review from a team July 17, 2023 18:18
@github-actions github-actions bot added the p2 label Jul 17, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 17, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@MrArnoldPalmer MrArnoldPalmer added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 17, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 17, 2023 19:30

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4e1b3cc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 267e42c into main Jul 18, 2023
6 checks passed
@mergify mergify bot deleted the fix/cr-error-checks branch July 18, 2023 07:41
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
Fixes bad error checking in custom resoruce for
cross-region-ssm-writer-handler and redshift cluster-reboot.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants