Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(trigger): fix incorrect construct id in README for aws-cdk-lib.triggers module #26436

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

tam0ri
Copy link
Contributor

@tam0ri tam0ri commented Jul 19, 2023

README for aws-cdk-lib.triggers module includes incorrect construct id myLambdaFunction.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.triggers-readme.html#usage

In the above example, the AWS Lambda function defined in myLambdaFunction will be invoked when the stack is deployed.

In my understanding, it should be MyTrigger.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 19, 2023 15:16
@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Jul 19, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b0fc90a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 898cda6 into aws:main Jul 19, 2023
6 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
…riggers module (aws#26436)

README for aws-cdk-lib.triggers module includes incorrect construct id `myLambdaFunction`. 
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.triggers-readme.html#usage
> In the above example, the AWS Lambda function defined in myLambdaFunction will be invoked when the stack is deployed.

In my understanding, it should be `MyTrigger`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants