Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: readme for hosted_zone tests #26547

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jul 28, 2023

Documents some unkowns around running integ tests with hosted zones.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 28, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 28, 2023 10:20
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 28, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 28, 2023
@mrgrain mrgrain requested a review from kaizencc July 28, 2023 14:04
@mrgrain
Copy link
Contributor Author

mrgrain commented Jul 28, 2023

@kaizencc Fixes the error message.

@mrgrain mrgrain self-assigned this Jul 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 28, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1e9de89
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9753039 into main Jul 28, 2023
9 checks passed
@mergify mergify bot deleted the mrgrain/chore/document-hosted-zone-tests branch July 28, 2023 15:51
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants