Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: java package names are incorrect for a number of packages #28121

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 23, 2023

In Java, the following services were all generated with an incorrect package name:

services.backupgateway
services.cleanrooms
services.entityresolution
services.healthimaging
services.mediapackagev2
services.osis
services.pcaconnectorad
services.proton
services.shield
services.verifiedpermissions
services.workspacesweb

Which all should have been:

software.amazon.awscdk.services.backupgateway
(etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

In Java, the following services were all generated with an incorrect
package name:

```
services.backupgateway
services.cleanrooms
services.entityresolution
services.healthimaging
services.mediapackagev2
services.osis
services.pcaconnectorad
services.proton
services.shield
services.verifiedpermissions
services.workspacesweb
```

Which all should have been:

```
software.amazon.awscdk.services.backupgateway
(etc)
```
@rix0rrr rix0rrr requested a review from a team November 23, 2023 17:31
@aws-cdk-automation aws-cdk-automation requested a review from a team November 23, 2023 17:31
@github-actions github-actions bot added the p2 label Nov 23, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 23, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: da20fc7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 24, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 24, 2023 08:43

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 24, 2023
Copy link
Contributor

mergify bot commented Nov 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b865320 into main Nov 24, 2023
33 of 35 checks passed
@mergify mergify bot deleted the huijbers/java-names branch November 24, 2023 09:04
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants