Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(amplify-alpha): add dependency from @aws-cdk/custom-resource-handlers #28373

Conversation

paulhcsun
Copy link
Contributor

Add dependency from from @aws-cdk/custom-resource-handlers to @aws-cdk/aws-amplify-alpha as part of effort to standardize custom resource creation and bundling of source code.

Verified addition with yarn install and yarn test.

Closes #28289.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 14, 2023 22:28
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Dec 14, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 14, 2023
@paulhcsun paulhcsun added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes p2 and removed bug This issue is a bug. p1 labels Dec 14, 2023
@paulhcsun paulhcsun removed the pr-linter/exempt-test The PR linter will not require test changes label Dec 14, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 846a985
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@paulhcsun paulhcsun marked this pull request as ready for review December 14, 2023 23:06
Copy link
Contributor

mergify bot commented Dec 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit be38982 into aws:main Dec 14, 2023
14 checks passed
@paulhcsun paulhcsun deleted the add-dependency-custom-resource-handlers-to-amplify-alpha branch December 14, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aws-cdk\aws-amplify-alpha: branch
3 participants