Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prlint): update second comment to state exemption request has been submitted #29000

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Feb 6, 2024

Issue # (if applicable)

Closes #28803

Reason for this change

If a contributor requests an exemption or clarification for a PR, they will get a second message (due to the comment event) telling them again that they can request an exemption/clarification. This may confuse contributors, especially beginners.

Description of changes

Detect if an exempt request comment already exists, next comment would mention an request has been submitted and waiting for a maintainer's review.

Description of how you validated changes

unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Feb 6, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 6, 2024 14:56
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 6, 2024
@GavinZZ GavinZZ marked this pull request as ready for review February 7, 2024 07:27
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, small comment. I am approving with the pr/do-not-merge label, which means that once my comment is addressed or discarded, you can remove the label and mergify will merge. No need to rerequest approval

tools/@aws-cdk/prlint/lint.ts Outdated Show resolved Hide resolved
@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Feb 9, 2024
@GavinZZ GavinZZ removed the pr/do-not-merge This PR should not be merged at this time. label Feb 9, 2024
Copy link
Contributor

mergify bot commented Feb 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c992d99
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 46dde1f into main Feb 9, 2024
12 checks passed
@mergify mergify bot deleted the yuanhaoz/prlint_exempt_request branch February 9, 2024 04:16
Copy link
Contributor

mergify bot commented Feb 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
…een submitted (#29000)

### Issue # (if applicable)

Closes #28803

### Reason for this change

If a contributor requests an exemption or clarification for a PR, they will get a second message (due to the comment event) telling them again that they can request an exemption/clarification. This may confuse contributors, especially beginners.

### Description of changes

Detect if an exempt request comment already exists, next comment would mention an request has been submitted and waiting for a maintainer's review.

### Description of how you validated changes

unit tests

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(prlint): instructions for exemption/clarification should not be shown if already requested
3 participants