chore(appconfig): fix eslint and update lambda extension arns #29005
Conversation
github-actions
bot
added
p2
admired-contributor
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
lets just put eslint-disable @aws-cdk/no-literal-partition at the top of this file
There was a problem hiding this comment.
Nice was looking for something like that. Updated
| @@ -437,48 +438,67 @@ export class Application extends ApplicationBase { | |||
|
|
|||
| const lambdaLayerVersions: {[key: string]: {[key: string]: string}} = { | |||
| [Platform.X86_64]: { | |||
| 'us-east-1': 'arn:aws:lambda:us-east-1:027255383542:layer:AWS-AppConfig-Extension:110', | |||
There was a problem hiding this comment.
The updates to what I assume are versioning numbers here... whats the story behind that? Separate from the goal of this PR, what is the maintenance strategy for keeping these arns up to date?
There was a problem hiding this comment.
These are updated with our latest lambda layer versions which customers can reference directly from here to add those layers to their lambdas without having to manually find the latest version themselves.
The plan is that whenever we release a new version, we will update this accordingly. I will make sure that this step gets added to our runbooks
There was a problem hiding this comment.
I will approve this PR since this convo is separate. But I don't think the plan of manually updating this map is acceptable in the long run. I also don't have a clear idea of what is going on here anyway. So more investigation is needed.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
### Reason for this change Getting rid of eslint exemptions in the file ### Description of changes Added some inline exemptions/fixed import ordering and also updated lambda layer version ARNs ### Description of how you validated changes ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Reason for this change
Getting rid of eslint exemptions in the file
Description of changes
Added some inline exemptions/fixed import ordering and also updated lambda layer version ARNs
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license