Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): DatabaseCluster.instanceEndpoints doesn't include writer endpoint #29337

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

badmintoncryer
Copy link
Contributor

Issue # (if applicable)

Closes #29279.

Reason for this change

DatabaseCluster.instanceEndpoints should include writer's endpoint but doesn't.

Description of changes

Add writer's endpoint to DatabaseCluster.instanceEndpoints

Description of how you validated changes

Add unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Mar 1, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 1, 2024 16:59
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Mar 1, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review March 1, 2024 17:00
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@badmintoncryer
Copy link
Contributor Author

Exemption Request
I think this modification doesn't need to add integ test.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Mar 1, 2024
@badmintoncryer badmintoncryer changed the title fix(rds): DatabaseCluster.instanceEndpoints doesn't include writer's endpoint fix(rds): DatabaseCluster.instanceEndpoints doesn't include writer endpoint Mar 7, 2024
@paulhcsun paulhcsun added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 8, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 8, 2024 19:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @badmintoncryer!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 8, 2024
Copy link
Contributor

mergify bot commented Mar 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e3468e7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ca59616 into aws:main Mar 8, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Mar 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer badmintoncryer deleted the 29279-instanceEndpoint branch March 9, 2024 01:45
@steffenjambit
Copy link

Thanks a lot for the fix @badmintoncryer!

@badmintoncryer
Copy link
Contributor Author

@steffenjambit You're welcome!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib/aws-rds/DatabaseCluster: DatabaseCluster.instanceEndpoints does not return writer endpoints
4 participants