Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sns): contentBasedDeduplication is always false for imported topic #29542

Merged
merged 12 commits into from
Apr 6, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Mar 19, 2024

Closes #29532.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK bug This issue is a bug. p2 labels Mar 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2024 21:02
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@msambol
Copy link
Contributor Author

msambol commented Mar 19, 2024

Exemption request: I don't believe an integration test is needed here.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 19, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 19, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 23, 2024
@msambol msambol force-pushed the 29532 branch 2 times, most recently from e427903 to 68f5d7b Compare March 25, 2024 01:45
@msambol
Copy link
Contributor Author

msambol commented Mar 25, 2024

@lpizzinidev This should be better now..

Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 👍
Left some comments for further adjustments.
Also, can you please add integration test coverage for the Topic.fromTopicArn and Topic.fromTopicAttributes methods?

packages/aws-cdk-lib/aws-sns/lib/topic.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-sns/lib/topic.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-sns/lib/topic.ts Show resolved Hide resolved
@msambol
Copy link
Contributor Author

msambol commented Mar 27, 2024

@lpizzinidev This should be better now.

Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
Looks good to me, just a final adjustment on the integration tests is needed in my opinion

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 27, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 27, 2024 15:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372 shikha372 self-assigned this Apr 4, 2024
@shikha372
Copy link
Contributor

shikha372 commented Apr 5, 2024

Thank you @msambol for your contribution, as per my understanding content based deduplication is available only for the FIFO queue, so if we are allowing users to set this value for imported topics, they might mistakenly set it for standard queue and face issue during deployment. Could we add validation that this is being set from attributes only in case in fifo queue.

@msambol
Copy link
Contributor Author

msambol commented Apr 5, 2024

Thank you @msambol for your contribution, as per my understanding content based deduplication is available only for the FIFO queue, so if we are allowing users to set this value for imported topics, they might mistakenly set it for standard queue and face issue during deployment. Could we add validation that this is being set from attributes only in case in fifo queue.

Great catch! Updated.

@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Apr 5, 2024
Copy link
Contributor

@shikha372 shikha372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .. Thank you @msambol for contributing and @lpizzinidev for review

Copy link
Contributor

mergify bot commented Apr 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 6, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ac70ae9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4a9e683 into aws:main Apr 6, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Apr 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sns.Topic.fromTopicArn: importinig topic forces contentBasedDeduplication = false
4 participants