Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "chore(eks): update ALB controller versions" #29941

Merged
merged 2 commits into from Apr 24, 2024
Merged

revert: "chore(eks): update ALB controller versions" #29941

merged 2 commits into from Apr 24, 2024

Conversation

paulhcsun
Copy link
Contributor

Reverts #29470

Reverting due to potential unwanted updating of resources with helm chart version changes.

@github-actions github-actions bot added the p2 label Apr 24, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 24, 2024 00:02
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 24, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@paulhcsun paulhcsun changed the title Revert "chore(eks): update ALB controller versions" revert "chore(eks): update ALB controller versions" Apr 24, 2024
@paulhcsun paulhcsun changed the title revert "chore(eks): update ALB controller versions" revert: "chore(eks): update ALB controller versions" Apr 24, 2024
@paulhcsun
Copy link
Contributor Author

@Mergifyio update

@aws-cdk-automation aws-cdk-automation dismissed their stale review April 24, 2024 00:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9142615
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 209ffd9 into main Apr 24, 2024
12 checks passed
@mergify mergify bot deleted the revert-29470-chore-eks-alb-controller-version branch April 24, 2024 00:35
This was referenced Apr 26, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xazhao xazhao xazhao approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulhcsun @aws-cdk-automation @xazhao