chore(lambda): hide warning if skipPermissions is set #30060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an user imports a lambda and wants to add permissions a warning is show. This warning should be skippable with the skipPermissions flag.
github-actions
bot
added
star-contributor
|
Exemption request - In my opinion this change neither needs an integration test nor an entry to the README. |
aws-cdk-automation
added
the
pr/needs-community-review
comcalvi
approved these changes
May 6, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #29887
Closes #29887
Reason for this change
If an user imports a lambda and wants to add permissions a warning is show. This warning should be skippable with the skipPermissions flag.
Description of how you validated changes
Unit tests for checking if the warning is shown/not shown depending on the value of
skipPermissionsare added.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license