Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): deprecate unsupported aurora mysql versions #30282

Merged
merged 6 commits into from
May 21, 2024

Conversation

colifran
Copy link
Contributor

@colifran colifran commented May 21, 2024

Reason for this change

The following Aurora MySQL versions are no longer supported by RDS:

  • 5.7.mysql_aurora.2.07.9
  • 5.7.mysql_aurora.2.07.10
  • 8.0.mysql_aurora.3.01.0
  • 8.0.mysql_aurora.3.01.1
  • 8.0.mysql_aurora.3.02.0
  • 8.0.mysql_aurora.3.02.1
  • 8.0.mysql_aurora.3.02.2
  • 8.0.mysql_aurora.3.02.3

See - https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.30Updates.html

Description of changes

Marked the unsupported Aurora MySQL versions as deprecated and fixed failing integ tests. I have also confirmed that these versions are not configurable via the RDS console.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation aws-cdk-automation requested a review from a team May 21, 2024 00:00
@github-actions github-actions bot added the p2 label May 21, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 21, 2024
@colifran colifran added the pr/do-not-merge This PR should not be merged at this time. label May 21, 2024
@colifran colifran marked this pull request as draft May 21, 2024 00:08
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@colifran colifran marked this pull request as ready for review May 21, 2024 00:12
@colifran colifran removed the pr/do-not-merge This PR should not be merged at this time. label May 21, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 21, 2024
@nmussy
Copy link
Contributor

nmussy commented May 21, 2024

These changes look good, but additionally for AuroraMysqlEngineVersion, 5.7.mysql_aurora.2.07.10 and 5.7.mysql_aurora.2.07.9 have been deprecated.

There are a few more added and deprecated versions, I can open another PR like #29422 to add all these changes if you'd like. Otherwise, here is the output of my CLI for all the RDS engine versions if you want to update them yourself:

RdsMySqlEngineRunner results:

[+] '5.7.44-rds.20240408'
[~] '5.7.37' + @deprecated
[~] '5.7.38' + @deprecated
[~] '5.7.39' + @deprecated
[~] '5.7.40' + @deprecated
[~] '5.7.41' + @deprecated
[~] '5.7.42' + @deprecated
[~] '5.7.43' + @deprecated
[~] '8.0.28' + @deprecated
[~] '8.0.31' + @deprecated


RdsMariaDbEngineRunner results:

[~] '10.4.27' + @deprecated
[~] '10.4.28' + @deprecated
[~] '10.5.18' + @deprecated
[~] '10.5.19' + @deprecated
[~] '10.6.10' + @deprecated
[~] '10.6.11' + @deprecated
[~] '10.6.12' + @deprecated


RdsPostgresEngineRunner results:

[+] '11.22-rds.20240418'
[+] '12.19'
[+] '13.15'
[+] '14.12'
[+] '15.7'
[~] '11.17' + @deprecated
[~] '11.18' + @deprecated
[~] '11.19' + @deprecated
[~] '11.20' + @deprecated
[~] '11.21' + @deprecated
[~] '12.12' + @deprecated
[~] '12.13' + @deprecated
[~] '12.14' + @deprecated
[~] '13.10' + @deprecated
[~] '13.8' + @deprecated
[~] '13.9' + @deprecated
[~] '14.5' + @deprecated
[~] '14.6' + @deprecated
[~] '14.7' + @deprecated
[~] '14.8' + @deprecated
[~] '15.2' + @deprecated
[~] '15.3' + @deprecated


RdsOracleEngineRunner results:

[+] '19.0.0.0.ru-2024-04.rur-2024-04.r1'
[+] '21.0.0.0.ru-2024-04.rur-2024-04.r1'


RdsSqlServerEngineRunner results:

[+] '15.00.4365.2.v1'
[+] '16.00.4115.5.v1'
[+] '16.00.4120.1.v1'

RdsAuroraMysqlEngineRunner results:

[+] '5.7.mysql_aurora.2.12.2'
[+] '8.0.mysql_aurora.3.04.2'
[~] '5.7.mysql_aurora.2.07.10' + @deprecated
[~] '5.7.mysql_aurora.2.07.9' + @deprecated


RdsAuroraPostgresEngineRunner results:

[+] '15.6'
[-] '16.3'

[+] represent additions to be made, [-] deletions, and [~] updates, in this case adding @deprecrated tags.

Note the last deletion, I ran my application on several regions and checked the web console, Postgres 16.3 was only added to classic RDS engines, not to Aurora as far as I can tell (see announcement)

Signed-off-by: Francis <colifran@amazon.com>
@colifran
Copy link
Contributor Author

colifran commented May 21, 2024

@nmussy thanks for the information! I've deprecated the other two Aurora MySQL versions. I think I'll keep this PR scoped to deprecating unsupported Aurora MySQL versions and let you continue on with the rest in a separate PR.

writer: rds.ClusterInstance.provisioned('Instance', {
instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE3, ec2.InstanceSize.SMALL),
instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE3, ec2.InstanceSize.MEDIUM),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the size increase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.0.mysql_aurora.3.06.0 can't be configured with an instance size small. It'll cause a deployment failure. The instance size has to be medium or large.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 21, 2024
Copy link
Contributor

mergify bot commented May 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 125f388
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 32e9b02 into main May 21, 2024
12 checks passed
@mergify mergify bot deleted the colifran/deprecate-aurora-mysql-versions branch May 21, 2024 18:04
Copy link
Contributor

mergify bot commented May 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@colifran colifran self-assigned this May 21, 2024
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this pull request May 22, 2024
### Reason for this change

The following Aurora MySQL versions are no longer supported by RDS:
- 5.7.mysql_aurora.2.07.9
- 5.7.mysql_aurora.2.07.10
- 8.0.mysql_aurora.3.01.0
- 8.0.mysql_aurora.3.01.1
- 8.0.mysql_aurora.3.02.0
- 8.0.mysql_aurora.3.02.1
- 8.0.mysql_aurora.3.02.2
- 8.0.mysql_aurora.3.02.3

See - https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.30Updates.html

### Description of changes

Marked the unsupported Aurora MySQL versions as deprecated and fixed failing integ tests. I have also confirmed that these versions are not configurable via the RDS console.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced May 27, 2024
atanaspam pushed a commit to atanaspam/aws-cdk that referenced this pull request Jun 3, 2024
### Reason for this change

The following Aurora MySQL versions are no longer supported by RDS:
- 5.7.mysql_aurora.2.07.9
- 5.7.mysql_aurora.2.07.10
- 8.0.mysql_aurora.3.01.0
- 8.0.mysql_aurora.3.01.1
- 8.0.mysql_aurora.3.02.0
- 8.0.mysql_aurora.3.02.1
- 8.0.mysql_aurora.3.02.2
- 8.0.mysql_aurora.3.02.3

See - https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.30Updates.html

### Description of changes

Marked the unsupported Aurora MySQL versions as deprecated and fixed failing integ tests. I have also confirmed that these versions are not configurable via the RDS console.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants