feat(ec2): security group lookup via filters #30625
Conversation
github-actions
bot
added
p2
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
jdukewich
changed the title
github-actions
bot
added
effort/small
|
Clarification Request Does this feature need a new integration test? If so, I'm struggling to figure out how to write one for a lookup like this. |
aws-cdk-automation
added
the
pr/reviewer-clarification-requested
|
Exemption Request |
aws-cdk-automation
added
the
pr-linter/exemption-requested
aws-cdk-automation
added
the
pr/needs-community-review
|
|
||
| // THEN | ||
| expect(securityGroup.securityGroupId).toEqual('sg-12345678'); | ||
| expect(securityGroup.allowAllOutbound).toEqual(true); |
There was a problem hiding this comment.
what happens if this matches more than one security group ?
There was a problem hiding this comment.
An error gets thrown in aws-cdk/lib/context-providers/security-group.ts for that case (and a test already exists for that case)
|
Hi there, I happened to be looking at this while you merged from main. In general, to do so please use the mergify command instead of using the button. |
@TheRealAmazonKendra Will do. Out of curiosity, why is that preferred? |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #30331.
Reason for this change
This will improve the security group lookup functionality for importing existing security groups into a CDK stack.
Description of changes
I added the ability to lookup existing security groups via more filters. Filters are supported by the DescribeSecurityGroups API, and using these filters can be immensely useful for looking up existing security groups, especially if your account or organization follows predictable rules regarding things like security group tags.
Description of how you validated changes
I added unit tests similar to the ones that test the normal lookup by ID or name.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license