Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events): dead letter queue for an Event Bus #30628

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat(events): dead letter queue for an Event Bus #30628

wants to merge 11 commits into from
+132 −48

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Jun 23, 2024 •
edited
Loading

Issue # (if applicable)

Closes #30531.

Reason for this change

EventBus L2 construct doesn't support for configuring dead letter queue.

Description of changes

Add deadLetterQueue prop to EventBusProps

Description of how you validated changes

Add both unit and integ test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jun 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 23, 2024 04:55
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jun 23, 2024
@badmintoncryer badmintoncryer changed the title feat(events): dead letter queue configuration of a Event Bus feat(events): dead letter queue configuration for an Event Bus Jun 23, 2024
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Jun 23, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review June 23, 2024 12:33
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Closed
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 24, 2024
@badmintoncryer badmintoncryer changed the title feat(events): dead letter queue configuration for an Event Bus feat(events): dead letter queue for an Event Bus Jun 24, 2024
@msambol
Copy link
Contributor

msambol commented Jun 28, 2024

Small nits re: the naming, otherwise LGTM.

@badmintoncryer
Copy link
Contributor Author

@msambol Thank you for your review!! I've addressed your comments.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b063dec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msambol msambol msambol left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

events: support dead letter queue for the event bus
3 participants
@badmintoncryer @msambol @aws-cdk-automation