Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): cannot specify part of execution data or task context as input to the RunLambda service integration #7428

Merged
merged 20 commits into from
Apr 23, 2020

Commits on Apr 18, 2020

  1. fix(stepfunctions-tasks): cannot specify part of execution data or ta…

    …sk context as input to the service integration
    
    The Lambda service integration requires an input field called `payload`.
    We modeled this as a `{[key: string]: any}` which precludes the usage of
    execution data or context data as inputs to a Lambda function.
    
    Fix:
    Change the type of `payload` to be `TaskInput` which has already modeled
    a type union for task classes that accept multiple types of payload.
    This will enable usage of literal strings, objects, execution data, and
    task context.
    
    Rationale:
    Although this is a breaking change, the workarounds for enabling usage of
    different types is not user friendly and incomplete as all of the types
    above cannot be expressed in the current modeling of `payload`
    
    Fixes #7371
    
    BREAKING CHANGE:
    `payload` in RunLambdaTask is now of type `TaskInput`.
    You can migrate your current assignment to payload by supplying it to the `TaskInput.fromObject()` API
    shivlaks committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    714c023 View commit details
    Browse the repository at this point in the history
  2. fix test expectations

    shivlaks committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    a74353d View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. update README

    shivlaks committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    7d91000 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1086bdb View commit details
    Browse the repository at this point in the history
  3. missed a merge conflict

    shivlaks committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    1a6cb7f View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Configuration menu
    Copy the full SHA
    4cae476 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    05ec5d4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e3fc24f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    389d580 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f157eb6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    edd4122 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    443e5d2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f053868 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. Apply suggestions from code review

    Co-Authored-By: Niranjan Jayakar <nija@amazon.com>
    shivlaks and Niranjan Jayakar committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    841074d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f6429f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    91892e8 View commit details
    Browse the repository at this point in the history
  4. missed a space

    shivlaks committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    1029f30 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Configuration menu
    Copy the full SHA
    a99b6c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc2e83d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f930df8 View commit details
    Browse the repository at this point in the history