Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apigateway): gateway responses #7441

Merged
merged 65 commits into from
Apr 27, 2020
Merged

feat(apigateway): gateway responses #7441

merged 65 commits into from
Apr 27, 2020

Conversation

nirvana124
Copy link
Contributor

@nirvana124 nirvana124 commented Apr 19, 2020 •
edited by nija-at

Commit Message

feat(apigateway): gateway responses (#7441)

closes #7071

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

pankajy93 and others added 30 commits February 28, 2020 18:08
@pankajy93
fix(apigateway): Allows configuring authorization scopes in apigatewa…
375a157 
…y method fixes#6390
@pankajy93
Fixes build failure for Case sensitive fields
37249b2
@nirvana124
Merge branch 'master' into master
bab8d99
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
71ab433 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
26c31ea 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/lib/method.ts
14dfbe7 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/test/test.method.ts
4612c83 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124 @nija-at
Update packages/@aws-cdk/aws-apigateway/test/test.method.ts
87cbb71 
Co-Authored-By: Niranjan Jayakar <16217941+nija-at@users.noreply.github.com>
@nirvana124
Merge branch 'master' into master
07a3188
@pankajy93
Added test cases to cover auth scopes absent and method options auth …
49d3752 
…scope take the priority in case method options and default options are passed
@pankajy93
Updating readme for authorizationScopes
3399253
@pankajy93
removing trailing white space to fix @aws-cdk/aws-apigateway: ERROR: …
913df38 
…/codebuild/output/src052287507/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-apigateway/lib/method.ts:80:87 - trailing whitespace
@nirvana124
Merge branch 'master' into master
3f451f7
@nirvana124
Merge branch 'master' into master
9b558f4
@pankajy93
adds comments under default integration and method section.
6b3e232
@nirvana124
Merge branch 'master' into master
7518e33
adjust lang in README
5cea74b
@pankajy93
Reolved conflicts
4660a32
@pankajy93
Merge branch 'master' of https://github.com/nirvana124/aws-cdk
c11dc30
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
3f75fca
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
b7b169e 
merge
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
0399ffc
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
7cf3b96
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
837193a
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
05b4c1a
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
cb11262
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
843e72c
@pankajy93
Merge branch 'master' of https://github.com/aws/aws-cdk
5b60952
@pankajy93
feat(apigateway) High level construct for ApiGateway GatewayResponse
99333ac
@nirvana124
Merge branch 'master' into nirvana124/GatewayResponse
45f032b
nija-at
nija-at previously approved these changes Apr 27, 2020
View reviewed changes
@mergify mergify bot dismissed nija-at’s stale review April 27, 2020 11:05

Pull request has been modified.

@nirvana124
Copy link
Contributor Author

@nija-at I just marked our conversation as resolved and bot dismissed your approval. Can you please re approve it. Apologies for inconvenience.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1cac02b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8137ee3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 481d79a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b5ac323
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8137ee3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b362aa6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1cac02b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b5ac323
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 481d79a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b362aa6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nirvana124 nirvana124 requested a review from nija-at April 27, 2020 11:36
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: dbdc03e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 60833e7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3e51e39
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b0a65c1 into aws:master Apr 27, 2020
@nirvana124 nirvana124 deleted the nirvana124/GatewayResponse branch April 28, 2020 04:20
@snyk-bot snyk-bot mentioned this pull request May 2, 2020
Merged
PatMyron
PatMyron reviewed Aug 14, 2020
View reviewed changes
packages/@aws-cdk/aws-apigateway/lib/gateway-response.ts
* Supported types of gateway responses.
* @see https://docs.aws.amazon.com/apigateway/latest/developerguide/supported-gateway-response-types.html
*/
export class ResponseType {
Copy link
Contributor

@PatMyron PatMyron Aug 14, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirvana124 Is this class automatically generated? If so, how?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatMyron PatMyron PatMyron left review comments

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define/Modify default API Gateway responses
5 participants
@nirvana124 @aws-cdk-automation @nija-at @PatMyron @pankajy93