Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add .vscode settings for eslint & some missed cleanup #7606

Merged
merged 3 commits into from
Apr 29, 2020
Merged

chore: add .vscode settings for eslint & some missed cleanup #7606

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7845b3
chore: add .vscode settings for eslint & some missed cleanup
Apr 25, 2020
ab1b564
Merge branch 'master' into nija-at/eslint-vscode
Apr 29, 2020
e790d28
Merge branch 'master' into nija-at/eslint-vscode
mergify[bot] Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# VSCode extension
.vscode/
/.favorites.json

# TypeScript incremental build states
Expand Down
8 changes: 8 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"eslint.workingDirectories": [
{ "pattern": "./packages/@aws-cdk/*" },
{ "pattern": "./packages/@monocdk-experiment/*" },
{ "pattern": "./packages/*" },
{ "pattern": "./tools/*" }
]
}
16 changes: 3 additions & 13 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,19 +287,9 @@ All packages in the repo use a standard base configuration found at [eslintrc.js
This can be customized for any package by modifying the `.eslintrc` file found at its root.

If you're using the VS Code and would like to see eslint violations on it, install the [eslint
extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint).

The following additional [VS Code setting](https://code.visualstudio.com/docs/getstarted/settings) is required when the
entire project is opened (not required if only a specific module is opened) -

```json
"eslint.workingDirectories": [
{ "pattern": "./packages/@aws-cdk/*" },
{ "pattern": "./packages/@monocdk-experiment/*" },
{ "pattern": "./packages/*" },
{ "pattern": "./tools/*" },
],
```
extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint). The VS Code setting [needed for
the extension to work](https://github.com/Microsoft/vscode-eslint#settings-options) on the monorepo is configured in
the [folder settings](https://code.visualstudio.com/docs/editor/multi-root-workspaces#_settings).

#### pkglint

Expand Down
7 changes: 0 additions & 7 deletions packages/@aws-cdk/cloud-assembly-schema/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,6 @@
"compat": "cdk-compat",
"update-schema": "bash scripts/update-schema.sh"
},
"cdk-build": {
"eslint": {
"ignore-pattern": [
"scripts/*"
]
}
},
"author": {
"name": "Amazon Web Services",
"url": "https://aws.amazon.com",
Expand Down
7 changes: 0 additions & 7 deletions tools/cfn2ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,6 @@
"jest": "^25.4.0",
"pkglint": "0.0.0"
},
"cdk-build": {
"eslint": {
"ignore-pattern": [
"test/enrichments/*.ts"
]
}
},
"keywords": [
"aws",
"cdk"
Expand Down