chore: add .vscode settings for eslint & some missed cleanup #7606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'eslint' section in package.json has been dropped. Clean up packages that were missed. - add `.vscode/settings.json` with eslint specific configuration so it's available automatically when the monorepo is opened in vscode.
|
cc @jogold |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Apr 29, 2020
|
Well we've talked around this a bunch and not settled on consensus really, so I'll be the instigator who says "yes I want this" |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
chore: add .vscode settings for eslint & some missed cleanup (#7606)
that were missed.
.vscode/settings.jsonwith eslint specific configuration so it'savailable automatically when the monorepo is opened in vscode.
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license