-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: "feat(lambda-nodejs): use docker instead of npm for parcel-bundler" #7738
revert: "feat(lambda-nodejs): use docker instead of npm for parcel-bundler" #7738
Conversation
…rcel-bundler" This reverts commit 55c4d0b.
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
The solution here is to install all the dependencies in the container before running If we do this then we'd better use a Lambda compatible docker image to do this ( |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
It was reverted (aws#7738).
@jogold @AlexCheema what's our plan to get this fixed? I hate to lose this feature. |
Reverts #7169
The
node_modules
folder or any other dependency/module that is not locatednext to the entry file is not present in the docker container. This means
that
parcel
cannot bundle anymore.