Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat(lambda-nodejs): use docker instead of npm for parcel-bundler" #7738

Merged

Conversation

jogold
Copy link
Contributor

@jogold jogold commented May 1, 2020

Reverts #7169

The node_modules folder or any other dependency/module that is not located
next to the entry file is not present in the docker container. This means
that parcel cannot bundle anymore.

@jogold
Copy link
Contributor Author

jogold commented May 1, 2020

@eladb @AlexCheema

@mergify
Copy link
Contributor

mergify bot commented May 1, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@jogold
Copy link
Contributor Author

jogold commented May 1, 2020

The solution here is to install all the dependencies in the container before running parcel.

If we do this then we'd better use a Lambda compatible docker image to do this (lambci). I already explored this, will try to open a PR soon.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f7527a9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold jogold changed the title Revert "feat(lambda-nodejs): use docker instead of npm for parcel-bundler" revert: "feat(lambda-nodejs): use docker instead of npm for parcel-bundler" May 1, 2020
@mergify
Copy link
Contributor

mergify bot commented May 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b723ba5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e26115a into aws:master May 1, 2020
jogold added a commit to jogold/aws-cdk that referenced this pull request May 6, 2020
@eladb
Copy link
Contributor

eladb commented May 7, 2020

@jogold @AlexCheema what's our plan to get this fixed? I hate to lose this feature.

eladb pushed a commit that referenced this pull request May 7, 2020
@jogold jogold deleted the revert-7169-alexcheema/docker-parcel-bundler branch May 7, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants